Rework how overriden otp types are compiled and loaded #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OTP 22 does not allow function specifications for functions residing in other modules any more. Fortunately this is not enforced by the parser but a later step of the compiler.
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=========================================
- Coverage 84.62% 84.6% -0.02%
=========================================
Files 12 13 +1
Lines 2211 2209 -2
=========================================
- Hits 1871 1869 -2
Misses 340 340
Continue to review full report at Codecov.
|
gomoripeti
force-pushed
the
prelude_v2
branch
from
f0ed469 to
25a5301
Compare
|
I'm merging since I think this is a fairly urgent PR to get in. I've been holding off on upgrading my erlang installation for this sole reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a bare minimum to allow compilation on OTP 22.