-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the seed-random dependency #1949
Comments
I'm fine with replacing the library with a different one if needed. Do you have an alternative in mind? |
Thanks. Glad to hear that. :) Actually I'm not familiar with the RNG algorithm. So, I'm not pretty sure about the alternative. You could evaluate it since you may know the algorithm better than me. And sure, there are others in the github search result. |
Sounds good to me to see if we can use https://github.com/davidbau/seedrandom instead. Anyone interested in trying this out? |
This fix is published now in |
Hi. Thanks for the nice tool.
I've used this in my work. But recently, I found that one of the dependencies of this lib makes some troubles for me. That's seed-random.
I've opened an issue here to describe the detail. To say it simply is that it depends on the whole global object from user and does some operations from that. But it could throw errors since we don't know what exists in user's global env.
And mathjs use it inside straight forward which may cause a crash by just import mathjs without doing anything.
I've mocked a module to bypass this problem. But seems that lib is not maintained for a long time. So, I come here for just a reminder. You could choose another RNG lib to avoid this risk if you like. :)
The text was updated successfully, but these errors were encountered: