Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript support #9

Open
TheGrinch00 opened this issue Dec 6, 2020 · 6 comments
Open

Typescript support #9

TheGrinch00 opened this issue Dec 6, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@TheGrinch00
Copy link

Hi, I'm trying to use your package with typescript but I could not find anywhere something like @types/amazon-paapi.
How should I find those ans install via npm?

@jorgerosal jorgerosal added the enhancement New feature or request label Mar 8, 2021
@jorgerosal jorgerosal self-assigned this Mar 8, 2021
@mattiaz9
Copy link

I created a typing myself. If you guys are interested you can get it here: https://gist.github.com/mattiaz9/3e31dbe50f573954d0f52cfcc6b220bf

Bear in mind that there may be errors or missing types.. I couldn't try the requests because of this #8

@TheGrinch00
Copy link
Author

Thank you so much @mattiaz9!

I'll look forward to use it as soon as I can to give you feedback about any issue I can find but I'm afraid it won't be anytime soon bc lately I've been very busy at work.

Anyway at first glance it looks fine, so thank you again

@EliaTolin
Copy link

I created a typing myself. If you guys are interested you can get it here: https://gist.github.com/mattiaz9/3e31dbe50f573954d0f52cfcc6b220bf

Bear in mind that there may be errors or missing types.. I couldn't try the requests because of this #8

How to use?

@mattiaz9
Copy link

How to use?

put the file amazon-paapi.d.ts inside your typings folder in your project.

Make sure you include the typings folder in the tsconfig.json:

{
  "include": [
    "typings"
  ]
}

@tka85
Copy link

tka85 commented Oct 9, 2023

@jorgerosal Can you please include the .d.ts file provided by @mattiaz9 in the project?

It is pretty straightforward and would benefit immensely the use of the package.

@sielay
Copy link

sielay commented Sep 21, 2024

AmazonSearchItemsResponse seems to be wrong

export type AmazonSearchItemsResponse = {
    Errors?: AmazonResponseError[];
-    VariationsResult: {
+    SearchResult: {
-      Items: AmazonVariation[];
+      Items: AmazonItem[];      
    };
  };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants