Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Add Dictionary to csv writer #508

Closed
ritchie46 opened this issue Oct 8, 2021 · 2 comments · Fixed by #515
Closed

Add Dictionary to csv writer #508

ritchie46 opened this issue Oct 8, 2021 · 2 comments · Fixed by #515
Assignees
@ritchie46
Labels
no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog

Comments

@ritchie46
Copy link
Collaborator

It's wasteful to first need to convert a dictionary to Utf8Array before we can write the csv.
@ritchie46 ritchie46 self-assigned this Oct 8, 2021
@ritchie46 ritchie46 mentioned this issue Oct 8, 2021
Closed
@ritchie46
Copy link
Collaborator Author

I closed this because I don't think it fits well in arrow dictionaries. Upon iteration we have to go through &dyn Scalar. I will implement something for the polars Categorical type.

@jorgecarleitao jorgecarleitao added the no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog label Oct 9, 2021
@jorgecarleitao
Copy link
Owner

jorgecarleitao commented Oct 9, 2021 •
edited
Loading

We can downcast the inner values to their corresponding type in writing, since there is only a small subset of datatypes to care about.

@ritchie46 ritchie46 reopened this Oct 9, 2021
@ritchie46 ritchie46 mentioned this issue Oct 9, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ritchie46 ritchie46

Labels
no-changelog Issues whose changes are covered by a PR and thus should not be shown in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add dictionary serialization for csv-writer ritchie46/arrow2
2 participants
@jorgecarleitao @ritchie46