Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong support detection on Windows #90

Closed
MartinKolarik opened this issue Jun 2, 2022 · 2 comments · Fixed by #91
Closed

Wrong support detection on Windows #90

MartinKolarik opened this issue Jun 2, 2022 · 2 comments · Fixed by #91

Comments

@MartinKolarik
Copy link
Contributor

This check assumes that anything running on Windows supports colors, which is not true and results in garbage output sometimes. For example, the GitHub Desktop app doesn't support colors for its output for precommit hooks and it sets env.TERM to dumb. Comparing with supports-color package which handles this correctly, this check should probably have a higher priority than the platform.
@jorgebucaran
Copy link
Owner

Could you submit a patch or show us in our code what we'd need to do to support your use-case on Windows? Thanks.

@MartinKolarik
Copy link
Contributor Author

Sure, I'll send a PR.

@MartinKolarik MartinKolarik mentioned this issue Jun 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix detection of dumb terminals on Windows MartinKolarik/colorette
2 participants
@jorgebucaran @MartinKolarik