Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect callback signature provided for "client.execute" in README.md #85

Open
sarus opened this issue Apr 30, 2014 · 0 comments
Open

Comments

@sarus
Copy link

sarus commented Apr 30, 2014

Hello,

The readme states that the callback for the client.execute() method returns an error parameter and the result set:

Callback should take two arguments err and result.

but the actual callback signature is:

args.callback(executeError, executionResult, retryCount);

which includes the retryCount as a third parameter.

Would recommend updating the README with the correct callback parameters as anyone using a library that expects the last parameter to be a callback function will run into errors (e.g., if you're using the async library)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant