You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@jordangarcia I'm curious as to why you made some of the decisions on 0.3.0?
why is Provider only a container element, I was assuming you were doing it because Babel 6 doesn't support decorators yet but noticed connect is still a decorator (assuming your decision is related to this Decision to remove the @provide decorator? reduxjs/react-redux#66?). Also, kind of a bummer you can no longer pass additional context as this was useful in our current apps, now would manually have to setup that context.
why does connect setup reactor.observe in componentWillMount. This potentially "solves" a lot of data binding issues I was having that I discussed with @Sinewyk because componentDidMount gets called from the inside out, so when binding initial state from actions in componentDidMount I would have to move this one level up above nuclearComponent to emit the Action. Seems easier this way but not very efficient if componentWillMount happens on both the client and server, seems pointless to setup reactor.observe on the server?
why is the anonymous function inside connect being called again in componentWillReceiveProps and reactor.observe being setup again here? Seems redundant? Previously this logic happened in componentDidMount
why is redux in peerDependencies and notnuclear-js` is there something going on I don't know about :-P?
The text was updated successfully, but these errors were encountered:
@jordangarcia I'm curious as to why you made some of the decisions on
0.3.0
?Provider
only a container element, I was assuming you were doing it because Babel 6 doesn't support decorators yet but noticedconnect
is still a decorator (assuming your decision is related to this Decision to remove the @provide decorator? reduxjs/react-redux#66?). Also, kind of a bummer you can no longer pass additionalcontext
as this was useful in our current apps, now would manually have to setup that context.connect
setupreactor.observe
incomponentWillMount
. This potentially "solves" a lot of data binding issues I was having that I discussed with @Sinewyk becausecomponentDidMount
gets called from the inside out, so when binding initial state from actions incomponentDidMount
I would have to move this one level up abovenuclearComponent
to emit the Action. Seems easier this way but not very efficient ifcomponentWillMount
happens on both theclient
andserver
, seems pointless to setupreactor.observe
on the server?connect
being called again incomponentWillReceiveProps
andreactor.observe
being setup again here? Seems redundant? Previously this logic happened incomponentDidMount
redux
inpeerDependencies and not
nuclear-js` is there something going on I don't know about :-P?The text was updated successfully, but these errors were encountered: