Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on 0.3.0 #14

Open
dtothefp opened this issue Dec 23, 2015 · 3 comments
Open

Comments on 0.3.0 #14

dtothefp opened this issue Dec 23, 2015 · 3 comments

Comments

@dtothefp
Copy link

@jordangarcia I'm curious as to why you made some of the decisions on 0.3.0?

  • why is Provider only a container element, I was assuming you were doing it because Babel 6 doesn't support decorators yet but noticed connect is still a decorator (assuming your decision is related to this Decision to remove the @provide decorator? reduxjs/react-redux#66?). Also, kind of a bummer you can no longer pass additional context as this was useful in our current apps, now would manually have to setup that context.
  • why does connect setup reactor.observe in componentWillMount. This potentially "solves" a lot of data binding issues I was having that I discussed with @Sinewyk because componentDidMount gets called from the inside out, so when binding initial state from actions in componentDidMount I would have to move this one level up above nuclearComponent to emit the Action. Seems easier this way but not very efficient if componentWillMount happens on both the client and server, seems pointless to setup reactor.observe on the server?
  • why is the anonymous function inside connect being called again in componentWillReceiveProps and reactor.observe being setup again here? Seems redundant? Previously this logic happened in componentDidMount
  • why is redux in peerDependencies and notnuclear-js` is there something going on I don't know about :-P?
@gf3
Copy link

gf3 commented Feb 17, 2016

cc: @jordangarcia

@singggum3b
Copy link

I think this repo is maintained by @Sinewyk ?

@Sinewyk
Copy link
Contributor

Sinewyk commented Mar 23, 2016

Kind of was. But I was not aware of the 0.3.0 so I can't answer this ^^.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants