Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor protocols, better documentation, more correct ASGI behaviour #108

Merged
merged 2 commits into from
May 15, 2020
Merged

Refactor protocols, better documentation, more correct ASGI behaviour #108

merged 2 commits into from
May 15, 2020

Conversation

jordaneremieff
Copy link
Collaborator

Refs #107

  • Lifespan is refactored into a context manager and run in the handler.
  • The enable_lifespan parameter is now deprecated. Since I had this one included in many examples for a large period of time the warning will be displayed until 0.10.0.
  • Introduced lifespan parameter for settings lifespan using 'auto', 'on', 'off'.
  • A lot of code comments about the ASGI cycle behaviour to make it easier to understand the flow.
  • The WebSocket and Lifespan protocols are more compliant with the ASGI spec.

@jordaneremieff
Docs
0cd2551
@jordaneremieff
Refactor lifespan, HTTP, WebSockets to be more consistent in behaviou…
58e9bd1 
…r, move things around, better docstrings/comments, pytest.ini
@jordaneremieff jordaneremieff merged commit df70493 into master May 15, 2020
@jordaneremieff jordaneremieff mentioned this pull request May 15, 2020
Closed
@jordaneremieff jordaneremieff deleted the fix-lifespan branch June 28, 2020 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jordaneremieff