Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker compose override #105

Open
yiendos opened this issue Jul 15, 2023 · 1 comment · May be fixed by #106
Open

docker compose override #105

yiendos opened this issue Jul 15, 2023 · 1 comment · May be fixed by #106

Comments

@yiendos
Copy link
Member

yiendos commented Jul 15, 2023

As soon as you change your main docker-compose.yml file, because it is versioned controlled:


→ git status
On branch master

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   docker-compose.yml
                                                                                                                                                                        
→ git pull --rebase
error: cannot pull with rebase: You have unstaged changes.
error: please commit or stash them.

This would prevent a user pulling the latest changes to the joomlatools-server, or contributing via Pull Request without first stashing or removing local changes.

It might be better to version control docker-compose.yml as the generic options, and then make use of a docker compose override file:
https://docs.docker.com/compose/extends/

Therefore as standard the joomlatools-server could ship with:

  • docker-compose.yml
  • sample-docker-compose-override.yml

Renaming sample-docker-compose-override.yml to docker-compose-override.yml would enable the JT server to pick up these changes during docker compose up.

yiendos added a commit that referenced this issue Jul 15, 2023
@github-actions github-actions bot linked a pull request Jul 15, 2023 that will close this issue
@yiendos
Copy link
Member Author

yiendos commented Jul 15, 2023

Note to self

Currently this can be invoked via:

docker compose -f docker-compose.yml -f docker-compose-override-sample.yml up -d

yiendos added a commit that referenced this issue Jul 15, 2023
- could work out how the string would be split into an array
- modified the creation of the array so that spaces would be delimeter instead
yiendos added a commit that referenced this issue Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant