-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode #313
Comments
Seems scss variables can't be used with a media prefers dark mode: Only support for root variables are possible: Take a look at first link and see how easy it would be to convert scss variables to css variables |
It seems that css variable support isn't that good: So I guess working out two stylesheets (admin.css and admin-dark.css):
At least this way the default |
@ercanozkaya question about fonts. Mason attempts to copy the fonts folder: from: to: Yet when you symlink joomlatools-framework into a site:
You can see the symlink is in fact made to: ~/Projects/joomlatools-framework/code/libraries/joomlatools/component/koowa/resources/assets/ So subsequent calls to the font folder fail:
What is the proper location for our fonts? Or is the way folders symlinked into the joomla console incorrect? |
@yiendos Fonts have been moved into The fonts should then come from |
@ercanozkaya mind giving this a spin please? Testing instructions
Let there be dark! |
@yiendos This is super super nice :) I think it looks better than it does on Wordpress since there is no sidebar either. Happy to incorporate this into core once we clean it up. We have a refactored loader in Foliokit for dark mode loader. Would you be willing to bring that over and also clean up the extra font files etc? Btw sorry for the late response this came right in between my holiday business so couldn't test earlier |
Seems there is a CSS proposal at present to introduce support for determining whether the user's browser has been configured to support Dark Mode:
https://stuffandnonsense.co.uk/blog/redesigning-your-product-and-website-for-dark-mode
It was agreed that if we could introduce this to the joomlatools-ui as a hidden Easter egg this would be fun for our users.
https://timble.slack.com/archives/C027CR8UF/p1570783467000200
The text was updated successfully, but these errors were encountered: