Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Option to show all articles in the new mod_articles #3297

Closed
jgerman-bot opened this issue Sep 28, 2024 · 0 comments · Fixed by #3302
Closed

[5.2] Option to show all articles in the new mod_articles #3297

jgerman-bot opened this issue Sep 28, 2024 · 0 comments · Fixed by #3302

Comments

@jgerman-bot
Copy link

New language relevant PR in upstream repo: joomla/joomla-cms#44127 Here are the upstream changes:

Click to expand the diff!
diff --git a/language/en-GB/mod_articles.ini b/language/en-GB/mod_articles.ini
index 853c1ea9eacd..7a9ced1a83f9 100644
--- a/language/en-GB/mod_articles.ini
+++ b/language/en-GB/mod_articles.ini
@@ -15,7 +15,7 @@ MOD_ARTICLES_FIELD_AUTHOR_LABEL="Authors"
 MOD_ARTICLES_FIELD_CATDEPTH_LABEL="Category Depth"
 MOD_ARTICLES_FIELD_CATFILTERINGTYPE_DESC="Include or exclude the selected categories."
 MOD_ARTICLES_FIELD_CATFILTERINGTYPE_LABEL="Category Filtering Type"
-MOD_ARTICLES_FIELD_COUNT_DESC="The number of items to display. The default value of 0 will display all articles."
+MOD_ARTICLES_FIELD_COUNT_DESC="The number of items to display. Set to 0 to show all articles."
 MOD_ARTICLES_FIELD_COUNT_LABEL="Articles to Display"
 MOD_ARTICLES_FIELD_DATEFIELDFORMAT_DESC="Please enter in a valid date format. See: https://php.net/date for formatting information."
 MOD_ARTICLES_FIELD_DATEFIELDFORMAT_LABEL="Date Format"
diff --git a/modules/mod_articles/mod_articles.xml b/modules/mod_articles/mod_articles.xml
index 7b63550fda33..1ae7df1860f2 100644
--- a/modules/mod_articles/mod_articles.xml
+++ b/modules/mod_articles/mod_articles.xml
@@ -28,9 +28,10 @@
 					name="count"
 					type="number"
 					label="MOD_ARTICLES_FIELD_COUNT_LABEL"
+					description="MOD_ARTICLES_FIELD_COUNT_DESC"
 					default="5"
 					filter="integer"
-					min="1"
+					min="0"
 					validate="number"
 				/>
 
@tecpromotion tecpromotion changed the title Option to show all articles in the new mod_articles [5.2] Option to show all articles in the new mod_articles Sep 29, 2024
tecpromotion added a commit to tecpromotion/joomla that referenced this issue Sep 29, 2024
@zero-24 zero-24 closed this as completed Oct 1, 2024
zero-24 added a commit that referenced this issue Oct 2, 2024
* fix #3297

* Update language/de-DE/mod_articles.ini

Co-authored-by: Tobias Zulauf <[email protected]>

---------

Co-authored-by: Tobias Zulauf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants