[4] media manager modal height

[micker]

hello i don't understand why modal in media manager doesn't use full heigh have device

For now we lost many space and we can't display more than 1 line of images ... that not clean ...
i think we have 2 solutions :

• take modal full height (or 90%)
• display thumb smaller

ex

[dgrammatiko]

@micker it's an easy fix, change

joomla-cms/layouts/joomla/form/field/media.php

Line 152 in d49e461

'bodyHeight' => '60',

to 'bodyHeight' => '80', Where 80 means 80% of the viewport

[micker]

did you think it interesting to propose a pr ?

[dgrammatiko]

Go ahead

[infograf768]

@dgrammatiko
That is the Image xtd, not the Change Image. The change has to be done in

joomla-cms/plugins/editors-xtd/image/image.php

Lines 95 to 102 in 0f955c8

	$button->options = [
	'height' => '400px',
	'width' => '800px',
	'bodyHeight' => '70',
	'modalWidth' => '80',
	'tinyPath' => $link,
	'confirmCallback' => 'Joomla.getImage(Joomla.selectedMediaFile, \'' . $name . '\', this)',
	'confirmText' => Text::_('PLG_IMAGE_BUTTON_INSERT')

Which does not mean the other one is not also necessary ;)

[dgrammatiko]

Personally I would apply the fix to both those files for consistency

[infograf768]

Yep, that's why I wrote

Which does not mean the other one is not also necessary ;)

Now, we have another issue: it is the waste of space between the images (media-main) and the footer.

[infograf768]

I mean

[micker]

yes need to change this too and find a solution for this
#30880

[micker]

hi its realy strange
if i set height 90 that doesn't works ... but in width value works ...


if i do 70 - 95

width value is good

for margin bottom i can propose this

if set

[infograf768]

height: calc(100vh - 153px); does not work here to reduce the gap between the footer and the body.

[micker]

yes maybe but at first (if we to test more) we need to find a work arround to have an 90% height for modal ,ot ?

[micker]

hello i update last ng with bs5
i can propose
.jviewport-height70 { height: 80vh; }
=> strange we can't do a .jviewport-height80
result

.media-main {
    height: calc(100vh - 104px);
}
.media-browser {
    height: calc(100vh - 155px);
}

Result

Some return ?
@infograf768 @dgrammatiko @C-Lodder

[dgrammatiko]

@micker change

joomla-cms/layouts/libraries/html/bootstrap/modal/body.php

Line 38 in 0220b8b

if ($bodyHeight && $bodyHeight >= 20 && $bodyHeight < 90)

to

if ($bodyHeight && $bodyHeight >= 20 && $bodyHeight <= 100)

[micker]

i didn't sse any difference, your code need to e added to my propose ?

[Equazar]

Hi, in Joomla 5.2 : add this lines in custom.css file

.joomla-dialog-media-field > dialog{ height: auto !important; }

It's do the trick

[Fedik]

In Joomla 5 the height is 80vh for large screens, and 96vh for smaller.
I would close this as not issue anymore. Well, I just noticed it is Discussion 😄