Other schema #271
Open
Other schema #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into 3.x-dev # Conflicts: # .drone.jsonnet # .drone.yml # Tests/AbstractDatabaseDriverTestCase.php # Tests/Mysql/MysqlDriverTest.php # Tests/Mysqli/MysqliDriverTest.php # Tests/Pgsql/PgsqlDriverTest.php # Tests/Sqlite/SqliteDriverTest.php # Tests/Sqlsrv/SqlsrvDriverTest.php # ruleset.xml # src/Command/ExportCommand.php # src/DatabaseDriver.php # src/DatabaseExporter.php # src/DatabaseImporter.php # src/Mysql/MysqlDriver.php # src/Mysql/MysqlImporter.php # src/Mysqli/MysqliDriver.php # src/Mysqli/MysqliImporter.php # src/Pgsql/PgsqlDriver.php # src/Sqlite/SqliteDriver.php
getTableList() return only tables not views
…/pr-301 Fixing failing tests
…ture/rewrite-multiple-prepared-parameters Rewrite multiple prepared parameters
…work#300) Appveyor fail is unrelated
AppVeyor fail is unrelated
…la-framework#307) AppVeyor fail is unrelated
AppVeyor fail is unrelated
…ork#304) AppVeyor fail is unrelated
|
As far as I can see by review, this PR will not work if either the schema name or the table name or both contain a dot, which is quite valid when the name which has a dot is name quoted. E.g. Another question is why does this PR add that functionality only to the getTableColumns method and not to any other method which takes a table name as argument. So in my opinion this PR should not be merged as it is. But other opinions are welcome. |
Extract host and port number or socket name from host option for mysql and pgsql drivers
…mber [3.x] Allow to specify port number or UNIX socket in host option also for MySQL (PDO) and PostgreSQL (PDO)
…punit-appveyor-sql2017 [3.x] Use directory Tests/Sqlsrv in phpunit.appveyor_sql2017.xml.dist to fix failing AppVeyor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #
Summary of Changes
Support other then default schema for columns getting
Testing Instructions
In database:
create schema foo;
create table foo.test (id integer, name varchar(10));
In Joomla:
Call getTableColumns method for this table 'foo.test'.
Documentation Changes Required