Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urls that contain tree anywhere in the filepath break branch parsing #16

Closed
lehnerm opened this issue May 27, 2019 · 0 comments · Fixed by #14
Closed

Urls that contain tree anywhere in the filepath break branch parsing #16

lehnerm opened this issue May 27, 2019 · 0 comments · Fixed by #14

Comments

@lehnerm
Copy link

lehnerm commented May 27, 2019

The occurrence of tree in the url is checked without respect to position (see index.js), which leads to an error in parsing the correct branch from the url.

Example case:
https://github.com/contentful/extensions/blob/master/samples/content-tree/extension.json

Will return:
branch: 'extension.json'

Should return:
branch: 'master'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant