Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repository normalizer #15

Open
doowb opened this issue Sep 12, 2017 · 1 comment
Open

repository normalizer #15

doowb opened this issue Sep 12, 2017 · 1 comment

Comments

@doowb
Copy link
Collaborator

doowb commented Sep 12, 2017

This block is causing the repository value to be overwritten when it's already a string, which becomes an issue when the project name is scoped for use in npm.

Locally, I added a check to see if val is a string like the other if blocks and it seems to work. I'll submit a PR with tests when I have a chance but wanted to open this issue as a reminder.

@jonschlinkert
Copy link
Owner

k, as long as the value is always the correct type. Meaning it shouldn't be sometimes a string, and sometimes an object, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants