Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module doesn't work with ImagickBackend #24

Closed
bummzack opened this issue May 19, 2016 · 1 comment
Closed

Module doesn't work with ImagickBackend #24

bummzack opened this issue May 19, 2016 · 1 comment

Comments

@bummzack
Copy link
Contributor

bummzack commented May 19, 2016

When using the ImagickBackend instead of the GDBackend for image manipulation, the module crashes because ImagickBackend lacks the crop method.

Not entirely sure if this should be fixed in SilverStripe core instead (eg. extending the Image_Backend interface with some additional methods, such as crop and also implement them in the ImagickBackend)?

@jonom
Copy link
Owner

jonom commented Jul 25, 2016

Sorry for the delay @bummzack I was taking some time off.

Huh! Yes I think that the Image_Backend interface ideally needs a crop($top, $left, $width, $height) method added as does ImagickBackend.

Adding a new method to an interface would be a breaking change but we could add a crop method to ImagickBackend in the 3 branch as a short term thing. I know @tractorcow was looking at dropping the ImageBackend interface for SS4 and using a third party image manipulation API instead so it may be redundant to implement a fuller solution in 4, but I don't know if that has progressed.

@bummzack Do you want to open a PR on framework (3 branch) for adding a crop method to ImagickBackend? Alternatively if you want to add an extension to this module for ImagickBackend that achieves the same end I'll be happy to accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants