-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add Wayland support #55
Comments
Check if it is possible load xwayland on your phone, it should work transparently then. It does not look like support for colour adjustments have been added to Wayland yet, or at least I have not been able to find the API. Personally I am eagerly waiting for Wayland and Haiku to add colour adjustments support. |
redshift doesn't work on XWayland (here on Fedora 21 Alpha under wayland/gnome-session) at least without any changes. According to http://lists.freedesktop.org/archives/wayland-devel/2014-February/ (via: https://en.wikipedia.org/wiki/RandR ) there is a randr extension in wayland since February, but I didn't find any API or cli tool for it. |
Running In March I did successfully run Redshift in XWayland, so I don't know what has happened. (Have not retried.) |
As the OP is running Sailfish I thought it would be worth mentioning that it is now possible to run XWayland on it (http://talk.maemo.org/showthread.php?t=93828&page=2), so if you get the chance please do try if you can get Redshift to work (until it's possible to run Redshift on Wayland directly). |
redshift is broken on Fedora 21: Gnome Wayland ~ $ redshift -l 55.7:12.6 -t 5700:3600 -g 0.8 -m vidmode -v &
Location: 55.700001, 12.600000
Temperatures: 5700K at day, 3600K at night
Brightness: 1.00:1.00
Gamma: 0.800, 0.800, 0.800
Xlib: extension "XFree86-VidModeExtension" missing on display ":1".
X request failed: XF86VidModeQueryVersion
Failed to start adjustment method vidmode |
Have you tried |
Ya: $ redshift -l 55.7:12.6 -t 5700:3600 -g 0.8 -m randr
Screen 1 could not be found.
Failed to start adjustment method randr.
Job 1, “redshift -l 55.7:12.6 -t 5700:3600 -g 0.8 -m randr &” has ended |
I'm also running Sailfish and I'd be interested too in this feature. Any updates on Wayland supporting randr? |
Try removing your redshift.conf. Most people with |
It looks like there still is no support in Wayland and that Weston only supports it but utilising colord. |
now it doesn't do anything, it just wait after running the commnad. |
Are you running a virtual or physical machine? |
I'm running it on my laptop, it's not a virtual machine. ~ $ redshift -l 55.7:12.6 -t 5700:3600 -g 0.8 -m xrandr
Unknown adjustment method `xrandr'.
~ $ redshift -l 55.7:12.6 -t 5700:3600 -g 0.8 -m xgamma
Unknown adjustment method `xgamma'. |
Ok. |
this is what I'm getting ~ $ xgamma -gamma 0.8
Xlib: extension "XFree86-VidModeExtension" missing on display ":1".
Unable to query video extension version
~ $ xrandr
Screen 0: minimum 320 x 200, current 1280 x 800, maximum 8192 x 8192
XWAYLAND0 connected 1280x800+0+0 260mm x 160mm
[email protected] 0.00*+ |
How about |
I think that made a difference. no errors |
How about |
it didn't do anything |
That's weird. |
|
I am also on Jolla. Will see if can test this over the holidays. |
Jolla/Sailfish here too, did anyone test this? Comments only talk about testing, but I don't see successful result. |
It will not work with xrandr and xwayland, since the screen is managed by the wayland compositor, and there is no wayland protocol to se the color temperature (yet). |
Can this (theoretically) be done by gamma factors? |
randr and vidmode are not supported on wayland. |
I've written the support for some wayland compositors here: giucam@d3f54ed This surely could be implemented in lipstick so that would answer the OP's question, however first i think it is necessary to understand the security implications. In the wayland world clients must not have the ability to screw the user interface, and a protocol like that could surely allow clients to do so. |
@giucam That's very cool. It seems that your protocol does gamma adjustments directly. Would it be possible to have the protocol instead only allow adjusting the color temperature or perhaps a color overlay? Perhaps such a scheme could be more easily limited to avoid the security issues? |
@jonls It could work with the temperature directly, but i guess that would mean the compositors would need to do what colorramp.c does themselves. I don't really know anything about color management so that was easier for me, but it sure could be possible. I'm not sure that solves the security issue, though. |
There is an app called "Tint Overlay" for SailfishOS. https://openrepos.net/content/coderus/tint-overlay |
I just wanted to say thanks to @prahal and his gnomerr branch which saved my day (Debian 10 - GNOME 3.30). |
Look like there's talks of adding colour profile calibration functionality to Wayland (see here), so we may eventually see redshift working on there too. |
More details here, hope these are useful? |
For anyone struggling with installation on Fedora 30:
will install packages necessary for make process. Analyze output of |
gnomerr method : Updated vs master + fixes for gnome-shell 3.34 |
As quickly written by @ddevault, please consider the broader wayland ecosystem. |
Please consider merging https://github.com/minus7/redshift/tree/wayland in. |
@jonls is this still happening? Six years have passed... |
hi all! :D is there any1 here who knows anything about efforts on enlightenment? :D (with wayland primarily, but if it works on x, then i would appreciate any info about that as well. (previously i used mate, and now i really miss it!)) many thx for any help and for this nice gem! :) |
There are several forks working on wayland support (some of which that seem to work), but it works fine under X, as that is what it was built around. The ones from minus7 and CameronNemo seem to be referenced here and there. |
tldr: nothing important here @CubeTheThird ahh, so many thx!!! :) u just gave me back my belief in humanity, as when i rarely dare to ask for help, then mostly it yields something next to no help and waste of time :D btw a fast duckduckgo gave no relevant info, and ive seen no straightforward info around those forks, but i obtained them to make it happen on my own whenever i will have some time to breathe :D (however at least i can see thx to redshift; otherwise currently im just in the middle of a big migration, so i also couldnt check it out) |
The Arch User Repos package this fork, which has been working fine for me (using swaywm) for months. |
I do think this project is dead though. Last commit was over a year ago. Hopefully someone might fork it and bring it back to life -- in the meantime, that fork is perfectly usable. |
abandonware!=deadware; that will turn out to be true or not when it wont work anymore if ppl will fix it or not, while the pending issues probably belong to those who dont care enough, not to the happy users :D |
What's stopping you from using this at it's state/packaging for your favorite distro? |
@prahal Thanks for the gnomerr fork! Is there any way to restrict it to specific display(s) on a screen?
|
@jonjonw gnomerr is based on randr plugin. I was not aware of the config syntax for the crtc handling. Thanks for the pointer. All that is required is change the section from randr to gnomerr.
|
This exact issue. I don't think there's been any activity on this repository in general though. The fork kinda works for me, so I guess that's good enough. 🤷 |
It doesn't. redshift makes the screen less bright, which is critical. With gnome Night Shift, one gets a bright redlight screen. |
GNOME's night light also does not adjust colour temperature during the day. |
Anything new? |
A fork, gammastep, exists with some light fixes to the PR linked above. https://gitlab.com/chinstrap/gammastep |
@CameronNemo thanks for the link. I have now moved gammastep to Arch Linux' [community] repository instead. I don't believe this ticket will go anywhere and I'll unsubscribe. |
I'd suggest others needing this feature just jump onto |
Another alternative: https://sr.ht/~kennylevinsen/wlsunset/ |
I use a Jolla phone with SailfishOS which already uses Wayland as display server. One thing I'm really missing is color shift in the dark. Is there something similar to the X server extension used for Wayland?
The text was updated successfully, but these errors were encountered: