Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Crash when media download location prompts more than once #576

Closed
geominorai opened this issue Nov 28, 2022 · 0 comments
Closed

[BUG] Crash when media download location prompts more than once #576

geominorai opened this issue Nov 28, 2022 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@geominorai
Copy link

Describe the bug

When the download handling is set to ask, the app will crash if you tap any media download button more than once, causing the file browser to open multiple times but crash the app when closing the last one.

This seems to be caused by the UI not blocking the download button from being pressed again while the file browser is still loading and yet to appear.

The crash happens regardless of whether a file name is chosen for the download or if the file browser is backed out. (Side note: Normally if you back out without choosing a file name, it does not crash but still shows a banner at the bottom saying it's downloading the media despite canceling.)

To Reproduce

Steps to reproduce the behavior:

  1. Set download handling to always ask.
  2. Open any image post.
  3. Tap the download button multiple times in quick succession.
  4. Close all file browser popups (one for each click of the download button).
  5. See crash.

Device

Model: Samsung Galaxy S9+
OS: Android 10
Language: English
Fritter Version: v3.0.0-beta5

@geominorai geominorai added the bug Something isn't working label Nov 28, 2022
@jonjomckay jonjomckay added this to the v3.0.0 milestone Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants