-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inferno 0.11.8
removed sealed CollapsePrivate
trait from public API
#264
Comments
Looks like this was caused by b8f9260 which reduced the public API surface. Sadly blanket trait impls on public traits are themselves public, regardless of the visibility of the bounds. The solution here (as described in rust-lang/rust#34537 among other places) is to treat |
inferno 0.11.8
leaks crate-private trait CollapsePrivate
inferno 0.11.8
removed sealed traits from public API
It needs to be in the public API due to the blanket implementation of `Collapse` for `T: CollapsePrivate`. The `inferno::collapse::common` module is crate-private, ensuring that `CollapsePrivate` and `Occurrences` cannot be named by downstream library users. Closes jonhoo#264.
inferno 0.11.8
removed sealed traits from public APIinferno 0.11.8
removed sealed CollapsePrivate
trait from public API
It needs to be in the public API due to the blanket implementation of `Collapse` for `T: CollapsePrivate`. The `inferno::collapse::common` module is crate-private, ensuring that `CollapsePrivate` and `Occurrences` cannot be named by downstream library users. Closes jonhoo#264.
We use
pprof
for benchmark profiling, which depends oninferno
. The most recent update caused this failure in our CI, whileinferno 0.11.7
compiles fine:The text was updated successfully, but these errors were encountered: