Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First coordinate skipped when populating alignment arrays #4

Open
atarsha opened this issue Jan 13, 2016 · 1 comment
Open

First coordinate skipped when populating alignment arrays #4

atarsha opened this issue Jan 13, 2016 · 1 comment

Comments

@atarsha
Copy link

atarsha commented Jan 13, 2016

Hi Jon,

I'm not sure if I've followed your code exactly right, but in the align_tracks() routine while loop, you maintain i > 0 || j > 0.

The children if statements then decide which alignment sequence to apply the coordinate to.

If I'm right, this means the final coordinate track1[0] and track2[0] NEVER get prepended onto a1 and a2

My testing seems to support this, but I have rewritten a lot of this in PHP so it may be a flaw on my part, but logically I see the same issue with the python code.

Your images on your blog seem to support this as well with the initial coordinate not being blue.

I'm trying to figure this out on my end, unfortunately, I'm not extremely familiar with these matrixes, and obviously if i == 0, i-1 is an undefined index which would break these if statements.

Any insight?

@atarsha
Copy link
Author

atarsha commented Jan 13, 2016

Oh, and I should have prefaced this by saying, thank you for sharing your code. It has been interesting to tinker with it and consider this algorithm for comparing GPS tracks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant