Implement JsonSchemaAs for OneOrMany instead of JsonSchema #760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is an
impl JsonSchema for WrapSchema<OneOrMany<...>>
. This works fine if you only directly needOneOrMany
but causes errors if you want to nest it (e.g.Option<OneOrMany<_>>
).This PR changes the impl to a
JsonSchemaAs
impl, which is the correct approach. I think I just missed these ones during a rebase. In any case, the change should be fully backwards compatible due to the blanket schema impl.I have added a snapshot test. The actual snapshot doesn't matter - the real test is that the struct below compiles