Add support for arrays of arbitrary size (serde big array) #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both generics can be significantly simplified and don't need to depend on DeserializeAsWrap.
This is gated on the const-generics support available in version 1.51+. This includes basic nesting of types with serde_as and the conversion to a map.
The deserialization is partially unsafe since it writes into an uninitialized array element by element. The conversion from a map (in the serialized format) to an array of tuples (in rust) is new and not available without const-generics support.
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
- Coverage 77.17% 76.70% -0.47%
==========================================
Files 36 40 +4
Lines 2129 2142 +13
==========================================
Hits 1643 1643
- Misses 486 499 +13
Continue to review full report at Codecov.
|
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for arrays of arbitrary size.
This feature requires Rust 1.51+.
Mapping of arrays was available before, but limited to arrays of length 32.
All conversion methods are available for the array elements.
This is similar to the existing
serde-big-arraycrate with three important improvements:serde_asannotation.Due to the const generics support it is now also possible to deserialize a map into an array of tuple elements.
@est31 The array initialization without
Clonemight also be suitable forserde-big-array.