Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement way to get root SDK versions #129

Merged
merged 2 commits into from
Aug 6, 2018
Merged

improvement way to get root SDK versions #129

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4abef9
improvement way to get root SDK versions
yeomann Jul 24, 2018
840ddce
fix double quotes
yeomann Aug 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
apply plugin: 'com.android.library'

def safeExtGet(prop, fallback) {
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

repositories {
mavenCentral()
}
Expand All @@ -14,11 +18,11 @@ buildscript {
}

android {
compileSdkVersion 23
buildToolsVersion "23.0.1"
compileSdkVersion safeExtGet('compileSdkVersion', 26)
buildToolsVersion safeExtGet('buildToolsVersion', '26.0.3')
defaultConfig {
minSdkVersion 16
targetSdkVersion 23
minSdkVersion safeExtGet('minSdkVersion', 16)
targetSdkVersion safeExtGet('targetSdkVersion', 26)
versionCode 1
versionName "1.0"
}
Expand All @@ -33,7 +37,7 @@ android {
}

dependencies {
compile 'com.facebook.react:react-native:+'
compile 'com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}'
//compile 'com.squareup.okhttp3:okhttp:+'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yeomann Thanks for this commit--it got me past the first hurdle adding rn-fetch-blob to a new project. Line 40 threw an exception during build though until I wrapped the string in double quotes. Could you apply a fix like that for the single quotes in single quotes issue?

(I haven't officially been added to this project yet, but I'm working with @Traviskn to merge this request as soon as possible.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh balls! my bad, it was actually suppose to be wrapped with double quotes, I have tested this multiple times, single quotes within single quotes doesn't work. let me fix it.

//{RNFetchBlob_PRE_0.28_DEPDENDENCY}
}