-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
very slow, Doesn't work with large datasets #89
Comments
Hm, yes I agree that there should be an option to set tolerance and maximum number of iterations. It looks like an easy fix too. I'm happy to consider pull requests if you or anyone else wants to contribute. |
I was going to parametrise it but I noticed my stats::nlm(f = optim_final_loss,
p = pars,
areas = areas_disjoint,
circle = circle,
iterlim = 1e6)$estimate Even with itterlim to 1 its still taking hours. Either the algorithm is slow or there is a bug. |
28 is not a small number, and I'm not actually sure that it makes sense to even try to use an Euler diagram here since the output is bound to be widely misleading. Finding good approximate Euler diagrams is hard even at 4 sets. The problem is that eulerr tries to compute the areas of the 2^28 - 1 = 268435455 possible intersections in the diagram, which is obviously not going to end well. It sounds like venn.js is doing something differently since it's as you say much faster, but I'm not really sure how it's possible to avoid considering all the intersections. |
Or, hm, actually it should absolutely be possible to alleviate this problem by ruling out some of the possible intersections, i.e. if A is not intersecting with C, then obviously A&C&whatever will also be empty, so yeah, this should be possible to fix (at least partially). |
Agreed. Its not the amount of nodes that matter, its the overlaps. I was thinking to do something like start off with just one overlap and keep increasing the overlaps until I find the outlier overlap that's causing the algorithm to stress over finding a solution. |
I'm having a similar issue, any solution? |
Meanwhile the browser Venn.js is instant, just less accurate.
Can there be some technique applied to speed it up or at least specify a stopping point for accuracy?
Thanks
The text was updated successfully, but these errors were encountered: