Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package does not work well with content scripts. #10

Open
jcblw opened this issue Jul 18, 2021 · 2 comments
Open

Package does not work well with content scripts. #10

jcblw opened this issue Jul 18, 2021 · 2 comments

Comments

@jcblw
Copy link
Contributor

jcblw commented Jul 18, 2021

Not all content scripts but content scripts that are defined in the manifest.

If you use content injection via browser.tabs.injectScript it works fine, but if you define content_script in your manifest the values are not updated until there is a reload. I feel we can catch this case, and if the user has this setup then we can easily make sure that it fully reloads on change of the content script.

@posobin pointed out to me in a Slack group ( BEP ) that it's because there is some heavy caching that Chrome does of these scripts.

@jcblw
Copy link
Contributor Author

jcblw commented Jul 18, 2021

Here is also a good and somewhat small sample repo.

https://github.com/mujo-code/json-inspector

@jcblw
Copy link
Contributor Author

jcblw commented Aug 18, 2021

Seems like Firefox regardless of dynamic injection or not caches scripts in a way that makes the content script refreshed useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant