Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore unknown tag type in incoming post, rather than raise exception #639

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

alphatownsman
Copy link
Contributor

@alphatownsman alphatownsman commented Aug 25, 2023

Various ActivityPub implementations and proposals introduced tag types, e.g. Edition from Bookwyrm and Link in fep-e232 Object Links, and assume this list will continue to grow.

Given most folks behind these changes will consider backward compatibility and making things pain-less for other implementations, it should be generally safe for us to just ignore the tag type and treat the post as is, rather than to raise exception and discard the whole post.

Personally, I think fep-e232 inline quote is really interesting, and backed by most implementations like Pleroma/Misskey/Firefish except Mastodon, but that can be its own pr in the future.

@andrewgodwin andrewgodwin merged commit 555046a into jointakahe:main Aug 25, 2023
3 checks passed
@andrewgodwin
Copy link
Member

Agreed - a lot of this code was written to raise exceptions when I was developing it so I could discover compat holes, but that's less useful now.

@alphatownsman alphatownsman deleted the ignore-unknown-tag-type branch January 14, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants