-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard against fetching local IP ranges #402
Comments
it would be good to have a development option to allow this, for testing federation for example. Perhaps an allow list of specific internal domain names to allow. |
GitLab has implemented a logic similar to this, where by default they block domains resolving to local networks, but having a whitelist for both domains and IPs (domains - regardless of the actual target IP) https://gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/30350 |
My suggestion is to make an httpx wrapper client that encapsulates all the fedi HTTP client extensions. So far, that's:
Future additions might include:
|
My plan was to instead do all of this in https://github.com/jointakahe/taktivitypub so it's reuseable |
Oh. Did you want #679? |
If you can make #679 roughly net-neutral in terms of code (i.e. remove the existing signing in the same PR) that's good to me. I don't know what the timeline would be for adding into the other thing. |
Anything that resolves to local IP ranges should not be allowed for actor fetching.
The text was updated successfully, but these errors were encountered: