Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui(send): add warn sign to selected jar on precondition violations #648

Merged
merged 4 commits into from
Aug 28, 2023
Merged

ui(send): add warn sign to selected jar on precondition violations #648

merged 4 commits into from
Aug 28, 2023

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Aug 24, 2023 •
edited
Loading

Part of #516.

This PR contains following changes

  • add a warning sign to the selected jar on the Send page, if some preconditions are not met (e.g. not enough confirmations, no tries left, etc.).
  • add a checkmark to the "payment success" alert
  • improve "collaborative transaction in progress" alert

Precondition warning

📸 Before

📸 After

Payment success

📸 Before / After

Collaborative transaction in progress

📸 Before / After

@theborakompanioni theborakompanioni added the UI/UX Issue related to cosmetics, design, or user experience label Aug 24, 2023
@theborakompanioni theborakompanioni self-assigned this Aug 24, 2023
@theborakompanioni theborakompanioni marked this pull request as ready for review August 24, 2023 12:14
httpiga
httpiga approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@httpiga httpiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!

@theborakompanioni theborakompanioni merged commit 77c3ec9 into master Aug 28, 2023
3 checks passed
@theborakompanioni theborakompanioni deleted the feat/516-send-screen branch August 28, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@httpiga httpiga httpiga approved these changes

@editwentyone editwentyone Awaiting requested review from editwentyone

Assignees

@theborakompanioni theborakompanioni

Labels
UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theborakompanioni @httpiga