Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

myNode integration #80

Open
dergigi opened this issue Feb 9, 2022 · 12 comments
Open

myNode integration #80

dergigi opened this issue Feb 9, 2022 · 12 comments
Assignees
Labels
integration Issues related to full-node integrations
Milestone

Comments

@dergigi
Copy link
Contributor

dergigi commented Feb 9, 2022

@secondl1ght reached out to the myNode team already, see mynodebtc/mynode#628

@dergigi dergigi added the integration Issues related to full-node integrations label Feb 9, 2022
@dergigi dergigi added this to JAM Feb 9, 2022
@dergigi dergigi moved this to Backlog 🪵 in JAM Feb 9, 2022
@abhiShandy
Copy link

I am familiar with MyNode's software design, so I can take this up. However, I would like to know if we want to install it as Docker image or as node project.

@theborakompanioni
Copy link
Collaborator

I am familiar with MyNode's software design, so I can take this up. However, I would like to know if we want to install it as Docker image or as node project.

If it is possible I'd be in favor of using the Docker images. Just because it'd be more comfortable to make adaptions as the project progresses. However, I am not familiar with myNode, so they might already have a JoinMarket install and we'd just need the UI. What are your thoughts on this @abhiShandy and @secondl1ght?

@secondl1ght
Copy link
Member

myNode currently has JoinInBox, im not familiar with implementation either but is it possible to use the same joinmarket backend they are using for that?

@abhiShandy
Copy link

I think Joininbox is a set of Shell scripts which installs JM among other utilities. We can add this web-UI to that script and then launch both the JM daemon and web-UI using a systemd service.

@ghost
Copy link

ghost commented Mar 2, 2022

@secondl1ght You can definitely hook up Jam to an existing joinmarket instance that has the jmwalletd API service running. That's what the RaspiBlitz integration is doing as well. We also have a UI-only docker image as @theborakompanioni mentioned.

@secondl1ght
Copy link
Member

@abhiShandy I would say once the next Jam release happens (which should be soon) with some bug fixes let's get the myNode integration happening after that. Once v0.0.4 is released let's get Jam out to the myNode users! Even the current version seems to be working very well overall on the other node implementations so it looks like it is ready.

@secondl1ght
Copy link
Member

I think we are ready for myNode with the latest release! Would love to see Jam on there.

@ghost ghost modified the milestones: v0.0.8 - Jarring Jars, v0.1.0 - Tasty Parity Jun 20, 2022
@ghost ghost removed this from the v0.1.0 - Tasty Parity milestone Aug 9, 2022
@dergigi
Copy link
Contributor Author

dergigi commented Aug 10, 2022

Any update on this?

@abhiShandy
Copy link

I can look into it this weekend.

@dergigi
Copy link
Contributor Author

dergigi commented Sep 21, 2022

Let me know if there is something we can do on our side to move this forward @abhiShandy 🙏

@abhiShandy
Copy link

Created a draft PR: mynodebtc/mynode#710

@roarkjanis-resale
Copy link

This thread it a bit old but I thought I would post here as a MyNode user. It is awesome to have Jam in MyNode. I especially looking forward to trying it out since Wasabi Wallet and Sparrow Whirlpool didn't meet my expectations for coinjoin. However, I cannot get it to launch completely.

The first time it takes me through several getting started screens with information about Jam. But when it gets to the page that should allow me to create the wallet the screen disappears in milliseconds and shows the following error message.

image

I guess that may be a problem with the jmwalletd API service not running or something in the background Jam is looking for. I'm not technical enough to explore all of this at the terminal level but am a super user and happy to do some testing with you.

Here is also a short screen share video I made so you can see the split second appearance of the wallet page and then the error message.

https://watch.screencastify.com/v/aN0i6cq3CY2x3hQqCx2A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration Issues related to full-node integrations
Projects
Status: No status
Development

No branches or pull requests

6 participants