Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve TypedExpr.substitute and Declaration.substitute #1126

Closed
johnynek opened this issue Feb 6, 2024 · 1 comment · Fixed by #1313
Closed

improve TypedExpr.substitute and Declaration.substitute #1126

johnynek opened this issue Feb 6, 2024 · 1 comment · Fixed by #1313

Comments

@johnynek
Copy link
Owner

johnynek commented Feb 6, 2024

The unshadow algorithm in Code.Lambda added in this commit: dc5389b

could be used in TypedExpr and Declaration. Both of which give up and return None if they hit a condition where it is needed.

By making that change, we could make those functions always return, which could improve optimizations.
@johnynek johnynek mentioned this issue Mar 7, 2024
Closed
@johnynek
Copy link
Owner Author

actually Declaration.substitute is only used when we know we can't mask, so the more complex algorithm isn't needed there.

@johnynek johnynek mentioned this issue Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve TypedExpr.substitute issue 1126 johnynek/bosatsu
1 participant
@johnynek