-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set preferred size for a pane #228
Comments
We might need to introduce the internal concept of high/low priority views. What's currently happening is that the views are given the correct sizes. However, when we relayout, we distribute space from right to left. So if the last view has been shrunk, it will immediately be expanded to fill in the missing space! |
Percentage based size would also be nice. |
Make sure to consider the behaviour when adding a new frame. Should it take on its preferred size? Also, what happens when we reset the whole split view? How should space be allotted amongst multiple panes with preferred sizes? |
Purpose
As a developer I would like to set a preferred size for when the user double clicks a sash adjacent to a pane.
Proposal
Let's play with the idea of using
defaultSizes
purely for setting the sizes on initial mount. The main use case here is for applications to persist the layout.We can then introduce a concept of preferred size purely for use when resetting the panes' layout.
A good starting point would be to look at the VS Code Grid component.
Acceptance criteria
The text was updated successfully, but these errors were encountered: