Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "limit_execution" parameter in rule config #161

Closed
adrienyhuel opened this issue Sep 10, 2019 · 9 comments
Closed

Add "limit_execution" parameter in rule config #161

adrienyhuel opened this issue Sep 10, 2019 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@adrienyhuel
Copy link
Contributor

adrienyhuel commented Sep 10, 2019

Since you pulled elastalert from yelp/master, there is an useful feature included in elastalert : we can limit rule execution time with a cron expression (ie : by example, make a rule run only during working hours).

See : Yelp/elastalert#492

Can you add a input box in preaco, where we can set this parameter in rule config ("limit_execution") ?

@kklmm
Copy link

kklmm commented Sep 11, 2019

Related: would be great to have a per rule configuration for run_every parameter.
Added to master elastalert just recently:

Yelp/elastalert#497

@johnsusek johnsusek added the enhancement New feature or request label Nov 7, 2019
@nsano-rururu
Copy link
Collaborator

@adrienyhuel @kklemen

It is recognized that limit_execution has the following settings. Is there any?

limit_execution: "* 02-03 * * *"

Do you feel that the input fields and default values for Minute, Hour, Day, Month, and Week are all "*"?
If not, please tell us what kind of UI you want.

@adrienyhuel
Copy link
Contributor Author

@nsano-rururu

Yes, limit_execution seem to be a cron syntax.

The default value should be None, in order to not activate this function.
See : https://github.com/Yelp/elastalert/blob/1dc4f30f30d39a689f419ce19c7e2e4d67a50be3/elastalert/elastalert.py#L1253

For UI, basic string could be OK, as most of us understand crontab syntax.
For an enhancement, maybe you could use some graphical component, like https://github.com/karoletrych/vue-cron-editor.

@nsano-rururu
Copy link
Collaborator

@adrienyhuel

thank you for your answer. I didn't know vue-cron-editor. We are planning to add a setting screen using vue-cron-editor.

@nsano-rururu nsano-rururu pinned this issue Feb 27, 2021
@nsano-rururu
Copy link
Collaborator

@adrienyhuel

Is there any problem with the following feeling? If there is no problem, it will be released at the time of 1.8.0 release.
https://github.com/johnsusek/praeco/tree/limit_execution
1
2
3
4

@adrienyhuel
Copy link
Contributor Author

@nsano-rururu that looks great !

@nsano-rururu nsano-rururu self-assigned this Mar 8, 2021
@nsano-rururu
Copy link
Collaborator

Praeco has released a new docker image. 1.8.0
https://hub.docker.com/r/praecoapp/praeco

@nsano-rururu nsano-rururu unpinned this issue Mar 15, 2021
@adrienyhuel
Copy link
Contributor Author

@nsano-rururu we're going to test it asap

@nsano-rururu
Copy link
Collaborator

Close once. Please reopen if there is a problem.

Repository owner locked and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants