Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard syntax for including\excluding doesn't work. #83

Closed
DmitriyMV opened this issue Aug 14, 2014 · 4 comments
Closed

Wildcard syntax for including\excluding doesn't work. #83

DmitriyMV opened this issue Aug 14, 2014 · 4 comments

Comments

@DmitriyMV
Copy link

include(dependency('asm:asm:3.*'))doesn't work. See also #64

@johnrengelman
Copy link
Collaborator

Try include(dependency('asm:asm'))

@DmitriyMV
Copy link
Author

Try include(dependency('asm:asm'))

Works fine. Strange...

@johnrengelman
Copy link
Collaborator

Yeah, what's happening is the string is coerced into the Spec<ResolvedDependency> by splitting the string on :. So if there is not token in the field then it's not used in the spec. Just needs some love in that code to make it more robust and to allow pattern matching.

@johnrengelman
Copy link
Collaborator

So, I'm going to fix this, but it's going to use regex pattern matching on the different pieces and not the maven style syntax. So it will be

include(dependency('asm:asm:.*'))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants