Compiled module descriptor in shadow-2.0.2.jar

[sormuras]

shadow-2.0.2.jar contains the module-info.class from ASM project. It reports:

• org.objectweb.asm.commons (6.0)

as its name to the Java module system. Compiled module desriptors from other artifacts should not be present.

jar --describe-module reports:

[email protected] jar:file:///[...]shadow-2.0.2.jar/!module-info.class open
exports shadow.org.objectweb.asm.commons
requires java.base mandated
requires org.objectweb.asm transitive
requires org.objectweb.asm.tree transitive

[johnrengelman]

This is a Java 9 thing right?
I'm thinking we need to auto-configure Shadow to exclude module-info.class from dependencies.

[sormuras]

Sounds reasonable.

[swankjesse]

FYI, I tried to use exclude to exclude module-info.class but it didn’t work. Perhaps class files are special?

task shadedJar(type: ShadowJar) {
  classifier = null
  manifest.attributes 'Main-Class': 'com.squareup.exemplar.ExemplarServiceKt'

  from(project.convention.getPlugin(JavaPluginConvention).sourceSets.main.output)
  configurations = [project.configurations.runtime]
  exclude('META-INF/INDEX.LIST', 'META-INF/*.SF', 'META-INF/*.DSA', 'META-INF/*.RSA', 'module-info.class')
}

[johnrengelman]

Hmm, that should work. Theres nothing special about the file types for the exclude filter.

[swankjesse]

@johnrengelman it was my fault. In my project we defined a shadedJar task and I was executing the shadowJar task, which wasn’t honoring any of my customizations.

[johnrengelman]

Added this in 275382c