Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive updated node #3

Open
Jtfinlay opened this issue Jul 26, 2020 · 0 comments
Open

Receive updated node #3

Jtfinlay opened this issue Jul 26, 2020 · 0 comments

Comments

@Jtfinlay
Copy link

Great example repo, appreciate the starting point to using react nodes.

One issue I hit is that the component never receives any updated attributes. They only receive the default values. So if your nodeView is expected to update state, this will never happen by updating the attrs.

I worked around this by updating the this.node in reactNodeView on update, and using a callback to retrieve the node instead of passing in. That said, it isn't the most elegant solution and could use some investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant