Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mktemp possibly used unsafely #86

Closed
jungle-boogie opened this issue Nov 13, 2015 · 3 comments
Closed

mktemp possibly used unsafely #86

jungle-boogie opened this issue Nov 13, 2015 · 3 comments

Comments

@jungle-boogie
Copy link
Contributor

While researching issue #85, came across this during a build:

/tmp/mlr_test_util-19aa81.o: In functionwrite_temp_file_or_die':
lib/mlr_test_util.c:(.text+0x24): warning: warning: mktemp() possibly used unsafely; consider using mkstemp()
/tmp/mlr_test_util-435aca.o: In function write_temp_file_or_die': /home/vagrant/bin/miller/c/lib/mlr_test_util.c:10: warning: warning: mktemp() possibly used unsafely; consider using mkstemp() /tmp/mlr_test_util-cfe51b.o: In functionwrite_temp_file_or_die':
/home/vagrant/bin/miller/c/lib/mlr_test_util.c:10: warning: warning: mktemp() possibly used unsafely; consider using mkstemp()`

@johnkerl
Copy link
Owner

Thanks.

@johnkerl
Copy link
Owner

The last two are due to missing single quotes on your shell commands.

I'm sure there's a system-dependent regression here but I'm skeptical that your bisection has identified the culprit commit. In a couple days I'll get you some experiments to run if you don't mind.

Also I need to set up a FreeBSD VM or something to shorten these cross-platform debug cycles.

@johnkerl
Copy link
Owner

Oops commented on wrong issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants