Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper pinning for flake 8 and add test for flake8 main #14

Closed
avylove opened this issue Nov 29, 2022 · 1 comment
Closed

Remove upper pinning for flake 8 and add test for flake8 main #14

avylove opened this issue Nov 29, 2022 · 1 comment

Comments

@avylove
Copy link
Contributor

avylove commented Nov 29, 2022

When flake8 moved to 6.0, pip decided version 0.9.0 was the only one that would meet the requirements since the version was pinned in 0.9.1. Since the configuration loading is different in that version, the config was ignored. You fixed this a couple days later so thanks for addressing it quickly. However, removing the pinning of flake8 < 7 would be better because when flake8 7 comes out it's more likely to work with the latest version than with 0.9.0, which is what will get pulled otherwise.

It would also be good to add a CI test that runs against flake8 main. The test could be non-critical with the continue-on-error option or not. This way there would be heads-up about any breaking behavior coming down the line.

@john-hen
Copy link
Owner

That makes sense, thanks for elaborating on that. You want to do the PR? (I like adding contributors.) First thing is any easy change, and I can merge and release that quickly. The CI test probably takes a little more thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants