Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize App Name Across Platforms (#3576) #3579

Closed
wants to merge 2 commits into from

Conversation

jiongxuan
Copy link
Contributor

Description

This PR standardizes the application name across platforms to improve brand consistency.

The app name is now set to Super Productivity on Mac, and Super Prod on Android to avoid truncation issues.

Issues Resolved

Check List

  • [✅] New functionality includes testing.
  • [✅] New functionality has been documented in the README if applicable. (No needed)

@jiongxuan jiongxuan closed this Oct 13, 2024
@jiongxuan
Copy link
Contributor Author

jiongxuan commented Oct 13, 2024

Please hold on for a moment. I’ve discovered that changing the app name on Mac results in the creation of two different apps, which prevents upgrade installations. I’ll investigate further, and if this issue cannot be resolved, I will proceed with modifying only the Android name for now, without changing the Mac name.

@jiongxuan
Copy link
Contributor Author

The compatibility issue with renaming has turned out to be far more complex than I initially thought. I’ve tried the following approaches:

  1. Using CFBundleDisplayName to modify directly: It had no effect; the app name didn’t change.
  2. Using InfoPlist.strings with localization: The files weren’t properly copied, and it didn’t work.
  3. Using extraResources to copy the files: The localization files weren’t applied as expected.
  4. Using an afterPack hook to manually modify Info.plist: It was overly complex and produced unstable results.

Since none of these solutions resolved the issue, and for the sake of stability, I will resubmit this PR, only changing the Android app name, leaving other platforms unchanged. I’ll revisit this in the future if a better solution is found.

New PR: #3580 (android only)

@johannesjo
Copy link
Owner

Thanks for digging into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants