crypto: improve invalid arg type message for randomInt()

Use "must be a safe integer" rather than "must be safe integer". I believe the former is more easily understood/clear. PR-URL: nodejs#35089 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
joesepi · Oct 22, 2020 · 964e640 · 964e640
1 parent 2f88f4b
commit 964e640
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/internal/crypto/random.js b/lib/internal/crypto/random.js
@@ -144,10 +144,10 @@ function randomInt(min, max, callback) {
     throw new ERR_INVALID_CALLBACK(callback);
   }
   if (!NumberIsSafeInteger(min)) {
-    throw new ERR_INVALID_ARG_TYPE('min', 'safe integer', min);
+    throw new ERR_INVALID_ARG_TYPE('min', 'a safe integer', min);
   }
   if (!NumberIsSafeInteger(max)) {
-    throw new ERR_INVALID_ARG_TYPE('max', 'safe integer', max);
+    throw new ERR_INVALID_ARG_TYPE('max', 'a safe integer', max);
   }
   if (max <= min) {
     throw new ERR_OUT_OF_RANGE(

diff --git a/test/parallel/test-crypto-random.js b/test/parallel/test-crypto-random.js
@@ -394,13 +394,13 @@ assert.throws(
     const invalidMinError = {
       code: 'ERR_INVALID_ARG_TYPE',
       name: 'TypeError',
-      message: 'The "min" argument must be safe integer.' +
+      message: 'The "min" argument must be a safe integer.' +
                `${common.invalidArgTypeHelper(i)}`,
     };
     const invalidMaxError = {
       code: 'ERR_INVALID_ARG_TYPE',
       name: 'TypeError',
-      message: 'The "max" argument must be safe integer.' +
+      message: 'The "max" argument must be a safe integer.' +
                `${common.invalidArgTypeHelper(i)}`,
     };
 
@@ -441,7 +441,7 @@ assert.throws(
     {
       code: 'ERR_INVALID_ARG_TYPE',
       name: 'TypeError',
-      message: 'The "min" argument must be safe integer.' +
+      message: 'The "min" argument must be a safe integer.' +
       `${common.invalidArgTypeHelper(minInt - 1)}`,
     }
   );
@@ -451,7 +451,7 @@ assert.throws(
     {
       code: 'ERR_INVALID_ARG_TYPE',
       name: 'TypeError',
-      message: 'The "max" argument must be safe integer.' +
+      message: 'The "max" argument must be a safe integer.' +
       `${common.invalidArgTypeHelper(maxInt + 1)}`,
     }
   );