Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vec_proxy_compare method for era #3

Closed
joeroe opened this issue Nov 9, 2020 · 0 comments
Closed

Add vec_proxy_compare method for era #3

joeroe opened this issue Nov 9, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone
0.3.0

Comments

@joeroe
Copy link
Owner

joeroe commented Nov 9, 2020

Currently yr_era(x) == yr_era(y) is used in several places but I don't trust it.

It also might be better to only selectively compare eras, e.g. consider eras with different labels equal if all the significant parameters are the same. Then they should be able to be combined, with a warning that the labels will be changed.
@joeroe joeroe added the enhancement New feature or request label Nov 9, 2020
@joeroe joeroe closed this as completed in bb01455 Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@joeroe