Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precision argument to yr_transform() #23

Closed
joeroe opened this issue Nov 12, 2020 · 0 comments
Closed

Add precision argument to yr_transform() #23

joeroe opened this issue Nov 12, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@joeroe
Copy link
Owner

joeroe commented Nov 12, 2020

yr_transform() is precise with epoch transformations, which is appropriate for more recent years but unnecessarily messy for distant ones:

library("era")
yr(100000000, "BCE") %>% 
  yr_transform(era("mya"))
#> # mya years <yr[1]>:
#> [1] 100.0019
#> # Era: million years ago (mya): calendar (×1e+06) years, counted backwards from 1950

Created on 2020-11-12 by the reprex package (v0.3.0)

It would be nice to add an option to round the output to a desired level of precision in yr_transform().

@joeroe joeroe added this to the v0.3 (CRAN) milestone Nov 12, 2020
@joeroe joeroe added enhancement New feature or request good first issue Good for newcomers labels Nov 12, 2020
@joeroe joeroe closed this as completed in 557658d Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant