Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows compatibility #49

Open
1 task
joelibaceta opened this issue Dec 26, 2020 · 4 comments
Open
1 task

Fix windows compatibility #49

joelibaceta opened this issue Dec 26, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@joelibaceta
Copy link
Owner

joelibaceta commented Dec 26, 2020

Some incompatibilities do not allow this tool to run correctly on windows. I will list some of them:

  • The stty size command is used to obtain the terminal's size, which generates the unknown command error in windows.
@joelibaceta joelibaceta added the bug Something isn't working label Dec 26, 2020
@joelibaceta joelibaceta changed the title Windows compatibility Fix windows compatibility Dec 26, 2020
@ZSaberLv0
Copy link

maybe it's better to add an option to specifiy max width and max height?

@creativegamer03
Copy link
Contributor

creativegamer03 commented Mar 30, 2021

Actually, using os.get_terminal_size() can return a tuple of the console window's columns and lines, which can be useful for windows porting.

>>> import os
>>> os.get_terminal_size()
os.terminal_size(columns=160, lines=40)

@joelibaceta
Copy link
Owner Author

@creativegamer03 do you think you can do a PR with that?

@creativegamer03
Copy link
Contributor

@creativegamer03 do you think you can do a PR with that?

idk... I'll try tho..

@joelibaceta joelibaceta linked a pull request Apr 22, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants