Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine branch status? #56

Closed
mdbraber opened this issue Jan 12, 2022 · 6 comments
Closed

Combine branch status? #56

mdbraber opened this issue Jan 12, 2022 · 6 comments

Comments

@mdbraber
Copy link
Contributor

I'm still using my custom version of Fastmate everyday and enjoying it. I've recently been building a similar wrapper but for Todoist which I made in Swift. I saw you also created a 'combine' branch about a year ago using Swift. Do you (still) have any plans to port Fastmate from Obj-C to Swift?

@joelekstrom
Copy link
Owner

joelekstrom commented Jan 12, 2022

I do! I created that branch mostly to learn Combine, so it’s a bit problematic in the sense that it a probably “too reactive” since I deliberately tried to use it for pretty much everything to learn 😬 it does work though so feel free to fork that branch if you need.

However, take a look at the last few commits on master. I’ve started to slowly do a more sensible Swift rewrite. I pick the good parts from the Combine branch, but mostly try to do a 1-1 rewrite to Swift to keep changes minimal. When everything is migrated it’s easier to “Swiftify” stuff.

@mdbraber
Copy link
Contributor Author

Great - nice to hear! Are you indeed planning on using something like Swiftify.com when the rewriting is done?

@joelekstrom
Copy link
Owner

joelekstrom commented Jan 13, 2022

No. I prefer to just rewrite it myself and improve where needed. With "Swiftify" I mean after migrating, changing to using stuff like Combine KVO publishers instead of the KVOBlockObserver it's currently using in objc. 884477d is an example of this where I migrated to compile-time verified user default keys and KVO publishers

@joelekstrom
Copy link
Owner

😂 I'm sorry - I had forgotten to push the commits I talked about above. They are on master now...

@posguy99
Copy link

posguy99 commented Feb 1, 2022

I've recently been building a similar wrapper but for Todoist which I made in Swift.

Not that it's related to Fastmate, but I looked on your Github page and didn't see a Todoist wrapper. Are you doing anything that Todoist's own wrapper doesn't?

@mdbraber
Copy link
Contributor Author

mdbraber commented Feb 1, 2022

@posguy99 yes, I'm doing a native quick add window, support Applescript and integrate todoist-shortcuts to name a few. It's not ready for release yet, but works well already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants