You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The basic completion docs for try-completion (also applying to test-completion, all-completions, etc.) state (emphasis added):
In addition, to be acceptable, a completion must also match all the
regular expressions in ‘completion-regexp-list’. (Unless
COLLECTION is a function, in which case that function has to handle
‘completion-regexp-list’ itself.)
The COLLECTION function provided by eglot does not appear to consider completion-regexp-list. This variable is important for completion styles such as orderless, which put completion-regexp-list to heavy work for candidate refinement. Since most in-built completion tables are obarrays, alists, hashes, etc., the issue really only pertains to programmed completion, such as in eglot. I have a small patch to the proxies lambda which implements this, and works well in my testing. Let me know if you'd like to see a PR. See also oantolin/orderless#78. Thanks for eglot!
The text was updated successfully, but these errors were encountered:
jdtsmith
changed the title
`completion-regexp-list' is not respectedcompletion-regexp-list is not respected
Sep 3, 2021
In Emacs version 26.1, the docstring at the end of try-completion says: Additionally to this predicate, ‘completion-regexp-list’
is used to further constrain the set of candidates. To me, this means that try-completion internally takes care of filtering candidates according to completion-regexp-list. However, Eglot doesn't use all-completion. Isn't that the root cause of this issue?
I'm guessing here, but appropriately changing cl-remove-if-not to all-completion after the "all-completion" comment might just fix the issue.
Repository owner
locked and limited conversation to collaborators
Sep 3, 2021
The basic completion docs for
try-completion
(also applying totest-completion
,all-completions
, etc.) state (emphasis added):The COLLECTION function provided by eglot does not appear to consider
completion-regexp-list
. This variable is important for completion styles such as orderless, which putcompletion-regexp-list
to heavy work for candidate refinement. Since most in-built completion tables are obarrays, alists, hashes, etc., the issue really only pertains to programmed completion, such as in eglot. I have a small patch to theproxies
lambda which implements this, and works well in my testing. Let me know if you'd like to see a PR. See also oantolin/orderless#78. Thanks for eglot!The text was updated successfully, but these errors were encountered: