Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Go LS default to gopls #304

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Conversation

ilohmar
Copy link
Collaborator

@ilohmar ilohmar commented Sep 23, 2019

github.com/sourcegraph/go-langserver has been put on the backburner, and
the maintainers themselves advocate using Google's gopls instead. gopls
is actively developed and, although still labeled "alpha", already works
very nicely.


@joaotavora
Copy link
Owner

and the maintainers themselves advocate using Google's gopls instead

Can you include a reference to a source for this recommendation?

@ilohmar
Copy link
Collaborator Author

ilohmar commented Sep 23, 2019

Right at the start of https://github.com/sourcegraph/go-langserver/blob/master/README.md:

Note: We have deprioritized work on this language server for use in editors in favor of Google's
Go language server, gopls. It is in the best interests of the community to only have a single
language server.

It is my interpretation, especially of the second sentence, that gopls is the way to go (and I agree, but that's beside the point, I guess).

@joaotavora
Copy link
Owner

Alright, do you have FSF papers signed? (also important for your other contribution...)

@ilohmar
Copy link
Collaborator Author

ilohmar commented Sep 23, 2019

Oh, did you mean to include the reference in the commit message? Can surely do that as well...

@ilohmar
Copy link
Collaborator Author

ilohmar commented Sep 23, 2019

Yeah, papers signed for Emacs years ago. Also, I already contributed recently :)

@joaotavora
Copy link
Owner

Oh, did you mean to include the reference in the commit message?

I didn't, but redoing the commit message in the format used by Eglot's other commits is useful. In this case it would be:

Use gols server as a default for Go (#304)

Developers recommend it: see 
https://github.com/sourcegraph/go-langserver/blob/master/README.md:

* eglot (eglot-server-programs): Use gols.

* README.md: mention gols instead of go-langserver.

@ilohmar
Copy link
Collaborator Author

ilohmar commented Sep 23, 2019

Sure, I always forget that.. coming soon.

@ilohmar
Copy link
Collaborator Author

ilohmar commented Sep 23, 2019

It's gopls, really ;)

Developers recommend it: see
https://github.com/sourcegraph/go-langserver/blob/master/README.md

* eglot (eglot-server-programs): Use gopls.

* README.md: mention gopls instead of go-langserver.
@joaotavora
Copy link
Owner

Looks good.

@joaotavora joaotavora closed this Sep 23, 2019
@joaotavora joaotavora reopened this Sep 23, 2019
@joaotavora joaotavora merged commit 7f31f29 into joaotavora:master Sep 23, 2019
@ilohmar ilohmar deleted the gopls branch September 23, 2019 18:06
bhankas pushed a commit to bhankas/emacs that referenced this pull request Sep 19, 2022
Developers recommend it: see
https://github.com/sourcegraph/go-langserver/blob/master/README.md

* eglot (eglot-server-programs): Use gopls.

* README.md: mention gopls instead of go-langserver.
(#304: joaotavora/eglot#304
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this pull request Oct 12, 2022
Developers recommend it: see
https://github.com/sourcegraph/go-langserver/blob/master/README.md

* eglot (eglot-server-programs): Use gopls.

* README.md: mention gopls instead of go-langserver.

GitHub-reference: joaotavora/eglot#304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants