Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marked upgrade from 0.3.x to 0.5.x changed how markdown inside html is parsed #340

Open
city41 opened this issue Apr 5, 2019 · 1 comment

Comments

@city41
Copy link

city41 commented Apr 5, 2019

The recent-ish upgrade from marked 0.3.12 to 0.5.1 changed how markdown inside html is parsed.

I have html like this in my markdown files

## The series
<ul>
    <li>[part one: basic rendering](/articles/react-internals-part-one-basic-rendering)</li>
    <li>[part two: componentWillMount and componentDidMount](/articles/react-internals-part-two-componentWillMount-and-componentDidMount/)</li>
    <li>[part three: basic updating](/articles/react-internals-part-three-basic-updating)</li>
    <li>[part four: setState](/articles/react-internals-part-four-setState)</li>
    <li>**part five: transactions** <- you are here</li>
</ul>

With marked 0.3.12, it would parse the embedded markdown into html. Now it leaves it as is. Arguably the new behavior is more correct, but this should constitute a breaking change IMO.

I worked around this by installing [email protected] locally and forcing wintersmith to use it (with yarn you can add resolutions to your package.json file, or with npm you need to use npm-force-resolutions package.

@city41
Copy link
Author

city41 commented Apr 5, 2019

It looks like the marked team considers this a bug: markedjs/marked#985

Perhaps when they fix it, wintersmith could grab the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant