-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large increase in memory usage when upgrading to Turnip 4.4.0 #251
Comments
Thanks for the report! I am looking forward to a test case that helps reproducing the issue comparing 4.3 to 4.4. In any case if I read the comparison correctly the memory increase is at a factor of ~3. @enkessler As you created cuke_modeler and #244, do you have an idea what may be happening here? |
Yeah, that's probably due to So I'm guessing that it's a fixable problem. We just have to have a look at how long the Turnip internals need to hang on to the objects or maybe have it prune off parts of the tree that it knows that it doesn't need. |
Additionally, Because of all that, the CukeModeler models are 'bigger' than the Gherkin objects that they replaced. But we could, at the very least, throw out that extra data after the models are created inside of the Turnip code. |
@addersuk A test or sample project that reproduces the issues would be helpful but, in the mean time, stick this monkey patch in somewhere and see if it affects the numbers.
|
In a private repo we have seen a massive increase in memory usage of our app that is using turnip since we upgraded to Turnip 4.4.0
Before the upgrade we run two ruby threads on our CI server
After the upgrade to 4.4.0 with two threads
I'll try and create a test case to illustrate this as it is happening in a private repo that makes extensive usage of Gherkin feature files.
We suspect this is due to the move to cuke_modeler
The text was updated successfully, but these errors were encountered: