From cec4a4743dd65f0c8879881956ca390817029b4f Mon Sep 17 00:00:00 2001 From: Jonas Thiel Date: Wed, 17 Apr 2024 11:37:55 +0200 Subject: [PATCH 1/4] Remove custom "context" alias for spec --- spec/play_store/product_acknowledgements/response_spec.rb | 8 ++++---- spec/spec_helper.rb | 6 ------ 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/spec/play_store/product_acknowledgements/response_spec.rb b/spec/play_store/product_acknowledgements/response_spec.rb index e029a68..9e608cc 100644 --- a/spec/play_store/product_acknowledgements/response_spec.rb +++ b/spec/play_store/product_acknowledgements/response_spec.rb @@ -6,7 +6,7 @@ end describe "#acknowledged?" do - context "when result present" do + describe "when result present" do let(:result) { "" } let(:error_data) { nil } @@ -17,7 +17,7 @@ end end - context "when result is not present" do + describe "when result is not present" do let(:result) { nil } let(:error_data) { nil } @@ -30,7 +30,7 @@ end describe "#error" do - context "when error present" do + describe "when error present" do let(:result) { nil } let(:error_data) do Module.new do @@ -53,7 +53,7 @@ def body end end - context "when error is not present" do + describe "when error is not present" do let(:result) { "" } let(:error_data) { nil } diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 8b10098..2fd2786 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -38,12 +38,6 @@ def in_continuous_integration_environment? ENV["DEBUG"] && Google::APIClient.logger.level = Logger::DEBUG module MiniTest - class Spec - class << self - alias context describe - end - end - module Assertions # The first parameter must be ```true```, not coercible to true. def assert_true(obj, msg = nil) From d50f607f335982b71f940930833909901cc53d4f Mon Sep 17 00:00:00 2001 From: Jonas Thiel Date: Wed, 17 Apr 2024 11:39:10 +0200 Subject: [PATCH 2/4] Use "new" Minitest namespace --- spec/spec_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 2fd2786..56271d7 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -37,7 +37,7 @@ def in_continuous_integration_environment? ENV["DEBUG"] && Google::APIClient.logger.level = Logger::DEBUG -module MiniTest +module Minitest module Assertions # The first parameter must be ```true```, not coercible to true. def assert_true(obj, msg = nil) From 25262da0fbdc1a17638e2a1ba2d25a04368179a6 Mon Sep 17 00:00:00 2001 From: Jonas Thiel Date: Wed, 17 Apr 2024 11:41:19 +0200 Subject: [PATCH 3/4] Update Minitest to 5.22 --- candy_check.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/candy_check.gemspec b/candy_check.gemspec index f9edcbd..5990f17 100644 --- a/candy_check.gemspec +++ b/candy_check.gemspec @@ -30,7 +30,7 @@ Gem::Specification.new do |spec| spec.add_development_dependency "guard" spec.add_development_dependency "guard-minitest" spec.add_development_dependency "inch", "~> 0.7" - spec.add_development_dependency "minitest", "~> 5.10" + spec.add_development_dependency "minitest", "~> 5.22" spec.add_development_dependency "minitest-around", "~> 0.4" spec.add_development_dependency "minitest-focus" spec.add_development_dependency "pry" From 5d772a2f5652ce9d2c338b2720c7f4f45757f6ae Mon Sep 17 00:00:00 2001 From: Jonas Thiel Date: Wed, 17 Apr 2024 11:42:03 +0200 Subject: [PATCH 4/4] Test on jruby-9.4.6.0 --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 105e762..067c530 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -12,7 +12,7 @@ jobs: - "3.1" - "3.2" - "jruby-9.3.10.0" - - "jruby-9.4.1.0" + - "jruby-9.4.6.0" steps: - uses: actions/checkout@v3 - uses: ruby/setup-ruby@v1