Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Album art missing when in offline mode #573

Closed
smymm opened this issue Jan 8, 2024 · 12 comments
Closed

iOS: Album art missing when in offline mode #573

smymm opened this issue Jan 8, 2024 · 12 comments

Comments

@smymm
Copy link

smymm commented Jan 8, 2024

Latest version available for iOS: Album art missing for all downloaded content, when you are in Offline mode. Only empty boxes are being shown. In all locations, lists, now playing..

I checked previous related issues (already closed). It seems this was fixed only for Android version, but not for iOS.

Thanks.

@jmshrv
Copy link
Owner

jmshrv commented Jan 8, 2024

Did this happen after an update? There was a pretty big migration in how downloaded images were handled a while back, but nothing recent should have broken it

@smymm
Copy link
Author

smymm commented Jan 8, 2024

Hi!
I don't know, because this is the first version I installed (about 1-2 months ago). Maybe some other iOS user can report on the behavior in previous versions? Perhaps the problem has existed for a long time and has not been detected or reported until now?

With this (latest) version, this is happening since the beginning.

If you need more info, please let me know.
Thanks!

@Chaphasilor
Copy link
Collaborator

Does it show that images were downloaded on the "Downloads" page? And are the images working on that screen?

Also, you could try deleting all your downloads, then re-downloading it and sharing the logs here (as a file).

@smymm
Copy link
Author

smymm commented Jan 8, 2024

Hi!
No, in the "Downloads" page, in Offline mode images are not working (they are working in Online mode), and hey! I can see that it's showing "0 images" text...

"420 downloads"
"420 Items, 0 images"

If I press "Download missing images" button, text banner shows "No missing images found"

I'll try to delete, re-download and extract logs later.
Thanks.

@smymm
Copy link
Author

smymm commented Jan 9, 2024

Hi,
I extracted logs (from the iPad, it has the same version installed and the behavior is the same). Deleted everything, closed app and then I re-opened it and downloaded 1 album.
Attached log file (edited for privacy).
Let me know if you need more info.

Thanks!
Finamp logs 1 edited.txt

@Chaphasilor
Copy link
Collaborator

Okay, so one thing I noticed in the logs is that your items don't seem to have blurhashes, which are the preview images that can be used while the actual images are still loading. And for some reason the download code only downloads images if these blurhashes exists, so that might be why no images are downloaded at all.
I don't have any idea why the blurhashes are missing though. What server version are you using?

@smymm
Copy link
Author

smymm commented Jan 9, 2024

Server version is 10.8.12

@Chaphasilor
Copy link
Collaborator

Okay. Do you file paths contain any special characters, for example as described in jellyfin/jellyfin#10375 ?
And if you refresh your library in the jellyfin web app, or scroll through your albums, can you see the blurred covers showing briefly before the actual image is loaded? Best to test this on a slower connection if possible

@smymm
Copy link
Author

smymm commented Jan 9, 2024

No special characters in paths. And no noticeable blurred covers when scrolling, only "disc" shaped icon -> actual album cover directly.

Anyway, with those clues I started to think about the server. I compiled the Jellyfin server on my own.
I checked this jellyfin/jellyfin#7617 just in case it has something to do with this.

Then I checked my server logs:
[2024-01-09 12:01:31.590 +01:00] [WRN] [1] Emby.Server.Implementations.ApplicationHost: Skia not available. Will fallback to "NullImageEncoder".

Is Skia responsible of the blurred covers, and that could be the cause of the issue, and not Finamp?

Thank you for your help.

EDIT: Anyway, why Finamp require blurhashes (regardless of wheter they exist or not) in order to download actual images?

@Chaphasilor
Copy link
Collaborator

Chaphasilor commented Jan 9, 2024

I think so. The "disc" icon should not be shown, that's when the blurhash would be shown. It's loaded along with the other metadata like the title.

So yeah, fixing this issue should probably fix your download issues.
Ideally missing blurhashes should not be a problem for downloading images, but we'll fix that in the redesign beta :)

Keep me posted!

@jmshrv
Copy link
Owner

jmshrv commented Jan 11, 2024

Anyway, why Finamp require blurhashes (regardless of wheter they exist or not) in order to download actual images?

Finamp uses Blurhashes as a key to see if we've already downloaded an identical image. Before, it'd use the image ID directly, which would commonly result in duplicate album covers being downloaded when files had their own images (which is pretty common, especially if you manually tag your music). It should be possible to fallback on IDs if blurhashes aren't available for some reason, I assumed that they would just always be there

@Chaphasilor
Copy link
Collaborator

@smymm the download system has been improved as part of the redesign beta. This issue has also been fixed specifically, so you shouldn't have any problems with missing blurhashes anymore. There might be some issues when migrating, but worst case you'll have to reinstall the app and re-download your media to your device :)
You can check the beta out here: https://github.com/jmshrv/finamp/releases/tag/0.9.2-beta

I'll close this issue for now since it should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants