-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Album art missing when in offline mode #573
Comments
Did this happen after an update? There was a pretty big migration in how downloaded images were handled a while back, but nothing recent should have broken it |
Hi! With this (latest) version, this is happening since the beginning. If you need more info, please let me know. |
Does it show that images were downloaded on the "Downloads" page? And are the images working on that screen? Also, you could try deleting all your downloads, then re-downloading it and sharing the logs here (as a file). |
Hi! "420 downloads" If I press "Download missing images" button, text banner shows "No missing images found" I'll try to delete, re-download and extract logs later. |
Hi, Thanks! |
Okay, so one thing I noticed in the logs is that your items don't seem to have blurhashes, which are the preview images that can be used while the actual images are still loading. And for some reason the download code only downloads images if these blurhashes exists, so that might be why no images are downloaded at all. |
Server version is 10.8.12 |
Okay. Do you file paths contain any special characters, for example as described in jellyfin/jellyfin#10375 ? |
No special characters in paths. And no noticeable blurred covers when scrolling, only "disc" shaped icon -> actual album cover directly. Anyway, with those clues I started to think about the server. I compiled the Jellyfin server on my own. Then I checked my server logs: Is Skia responsible of the blurred covers, and that could be the cause of the issue, and not Finamp? Thank you for your help. EDIT: Anyway, why Finamp require blurhashes (regardless of wheter they exist or not) in order to download actual images? |
I think so. The "disc" icon should not be shown, that's when the blurhash would be shown. It's loaded along with the other metadata like the title. So yeah, fixing this issue should probably fix your download issues. Keep me posted! |
Finamp uses Blurhashes as a key to see if we've already downloaded an identical image. Before, it'd use the image ID directly, which would commonly result in duplicate album covers being downloaded when files had their own images (which is pretty common, especially if you manually tag your music). It should be possible to fallback on IDs if blurhashes aren't available for some reason, I assumed that they would just always be there |
@smymm the download system has been improved as part of the redesign beta. This issue has also been fixed specifically, so you shouldn't have any problems with missing blurhashes anymore. There might be some issues when migrating, but worst case you'll have to reinstall the app and re-download your media to your device :) I'll close this issue for now since it should be resolved. |
Latest version available for iOS: Album art missing for all downloaded content, when you are in Offline mode. Only empty boxes are being shown. In all locations, lists, now playing..
I checked previous related issues (already closed). It seems this was fixed only for Android version, but not for iOS.
Thanks.
The text was updated successfully, but these errors were encountered: