diff --git a/src/nodes/conv.rs b/src/nodes/conv.rs index 6dd6a12..29e6b80 100644 --- a/src/nodes/conv.rs +++ b/src/nodes/conv.rs @@ -109,10 +109,11 @@ pub fn attr_fs_to_fuse(path: &Path, inode: u64, attr: &fs::Metadata) -> fuse::Fi attr.len() }; - // TODO(jmmv): Using the underlying ctimes is slightly wrong because the ctimes track changes - // to the inodes. In most cases, operations that flow via sandboxfs will affect the underlying - // ctime and propagate through here, which is fine, but other operations are purely in-memory. - // To properly handle those cases, we should have our own ctime handling. + // TODO(https://github.com/bazelbuild/sandboxfs/issues/43): Using the underlying ctimes is + // slightly wrong because the ctimes track changes to the inodes. In most cases, operations + // that flow via sandboxfs will affect the underlying ctime and propagate through here, which is + // fine, but other operations are purely in-memory. To properly handle those cases, we should + // have our own ctime handling. let ctime = Timespec { sec: attr.ctime(), nsec: attr.ctime_nsec() as i32 }; let perm = match attr.permissions().mode() { diff --git a/src/nodes/mod.rs b/src/nodes/mod.rs index a061e04..c7362fb 100644 --- a/src/nodes/mod.rs +++ b/src/nodes/mod.rs @@ -95,7 +95,8 @@ pub type NodeResult = Result; /// kernel, as computing the updated metadata here would be inaccurate. The reason is that we don't /// track ctimes ourselves so any modifications to the file cause the backing ctime to be updated /// and we need to obtain it. -/// TODO(jmmv): Compute the modified fuse::FileAttr and return it once we track ctimes. +/// TODO(https://github.com/bazelbuild/sandboxfs/issues/43): Compute the modified fuse::FileAttr and +/// return it once we track ctimes. /// /// This tries to apply as many properties as possible in case of errors. When errors occur, /// returns the first that was encountered.